Prevent 'Drive Not Ready' on completion for removable drives.#98
Open
Jule- wants to merge 1 commit intoliamcain:st3from
Open
Prevent 'Drive Not Ready' on completion for removable drives.#98Jule- wants to merge 1 commit intoliamcain:st3from
Jule- wants to merge 1 commit intoliamcain:st3from
Conversation
…trying to test removable drives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not a Python expert but I found some code to adapt, all credits to Adam Rosenfield : http://stackoverflow.com/a/4790310/4861714.
Fix issue #62.
This issue is due to
os.path.exists()method called on removable drives on Windows. It shows an error message box because Windows handle the 'Drive Not Ready' error itself. Googlewin32api.SetErrorMode(0)for more information. Sincewin32apiis not packaged with Sublime Text I opted for thectypes.cdll.kernel32.GetLogicalDrives()solution.I have not tested my patch on other platforms but for what I understand from code the
get_drivesmethod is Windows specific so it should not impact other platforms.